Updated logic to not allow attendee deselection from bill split confirmation page. #5895
Conversation
|
@shawnborton A question. Do we really need to show the checkboxes on the confirmation page if we can't deselect the users in the FAB flow? |
| @@ -65,6 +65,9 @@ const propTypes = { | |||
| phoneNumber: PropTypes.string, | |||
| })).isRequired, | |||
|
|
|||
| /** Amount split belongs to group or not */ | |||
There was a problem hiding this comment.
NAB: It can be improved. e.g. Whether this is an IOU split and belongs to a group report
There was a problem hiding this comment.
@parasharrajat thanks, I will update instruction as per your suggestion asap.
There was a problem hiding this comment.
Changes done. thanks.
There was a problem hiding this comment.
LGTM & tests well.
cc: @Julesssss ready for final review and merge when n6-hold is lifted.
| @@ -40,6 +40,9 @@ const propTypes = { | |||
|
|
|||
| /** IOU type */ | |||
| iouType: PropTypes.string, | |||
|
|
|||
| /** Amount split belongs to group or not */ | |||
There was a problem hiding this comment.
This can be changed similarly to the above comment.
There was a problem hiding this comment.
This also changed.
There was a problem hiding this comment.
LGTM. Tests well.
Ready for final review and merge when n6 is lifted. cc: @Julesssss
|
@parasharrajat FYI, N6 hold is lifted now |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @Julesssss in version: 1.1.8-10 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
@Julesssss pr is ready for review.
Details
If bill split flow initiated via FAB, we will Not Allow attendee deselection on bill split confirmation page.
If bill split flow initiated from Group Chat we will Allow attendee deselection on bill split confirmation page.
Discussion #5295 (comment) and #5295 (comment)
Confirmation: #5295 (comment)
Fixed Issues
$ #5295
Tests | QA Steps
QA Test1: Bill-split init via FAB
So in this case it Should Not Allow to deselect attendees on confirmation page.
QA Test2: Bill-split init via Group Chat
So in this case it Should Allow to deselect attendees.
Tested On
Screenshots
Web
Web.mov
Mobile Web
MobileWeb.mov
Desktop
Desktop.mov
iOS
iOS.mov
Android
Android.mov